Skip to content

⬆️ Maintenance: upgrade aiohttp, version 3.11.13 is yanked #7649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 9, 2025
Merged

⬆️ Maintenance: upgrade aiohttp, version 3.11.13 is yanked #7649

merged 13 commits into from
May 9, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented May 8, 2025

Due to aio-libs/aiohttp#10617 version 3.11.13 was yanked and since we use it here is a repository-wide upgrade.

Highlights on updated libraries (only updated libraries are included)

  • #packages before ~ 4
  • #packages after ~ 4
# name before after upgrade count packages
1 aiohttp 3.9.3, 3.11.1, 3.11.14, 3.8.5, 3.11.13, 3.11.12, 3.11.10, 3.10.10, 3.11.8, 3.9.5 3.11.18 41 agent⬆️🧪
api-server⬆️🧪
autoscaling⬆️
aws-library🧪
catalog⬆️🧪
clusters-keeper⬆️🧪
dask-sidecar⬆️
datcore-adapter⬆️
director-v2⬆️🧪
director⬆️🧪
docker-api-proxy🧪
dynamic-scheduler⬆️
dynamic-sidecar⬆️🧪
efs-guardian⬆️🧪
helpers🧪
invitations⬆️
notifications-library🧪
notifications⬆️
payments⬆️🧪
public-api🧪
resource-usage-tracker⬆️
service-library🧪🧪🧪
simcore-sdk🧪🧪
storage⬆️🧪
swarm-deploy🧪
tests🧪
web⬆️🧪
2 async-timeout 4.0.3 🗑️ removed 1 web🧪
3 propcache 0.2.0 0.3.1 minor 2 efs-guardian⬆️🧪
4 yarl 1.9.4, 1.15.4 1.20.0 minor 7 datcore-adapter⬆️
efs-guardian⬆️🧪
helpers🧪
resource-usage-tracker⬆️
web⬆️🧪

Legend:

  • ⬆️ base dependency (only services because packages are floating)
  • 🧪 test dependency
  • 🔧 tool dependency

@sanderegg sanderegg added this to the Bazinga! milestone May 8, 2025
@sanderegg sanderegg self-assigned this May 8, 2025
@sanderegg sanderegg added the t:maintenance Some planned maintenance work label May 8, 2025
matusdrobuliak66
matusdrobuliak66 approved these changes May 8, 2025
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks a lot

@codecov
Copy link

codecov bot commented May 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.50%. Comparing base (25ce7b5) to head (919c5e3).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7649      +/-   ##
==========================================
- Coverage   87.72%   87.50%   -0.23%     
==========================================
  Files        1791     1446     -345     
  Lines       69088    59592    -9496     
  Branches     1134      660     -474     
==========================================
- Hits        60608    52143    -8465     
+ Misses       8169     7244     -925     
+ Partials      311      205     -106
Flag Coverage Δ
integrationtests 64.95% <33.33%> (-0.01%) ⬇️
unittests 86.59% <90.00%> (-0.36%) ⬇️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library 93.92% <ø> (ø)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 73.02% <85.71%> (ø)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.66% <100.00%> (ø)
agent 96.46% <ø> (ø)
api_server 92.50% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.64% <ø> (ø)
clusters_keeper 99.25% <ø> (ø)
dask_sidecar 89.88% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.80% <ø> (ø)
director_v2 91.07% <ø> (-0.08%) ⬇️
dynamic_scheduler 96.76% <ø> (ø)
dynamic_sidecar 90.15% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.63% <ø> (ø)
resource_usage_tracker 88.91% <ø> (-0.22%) ⬇️
storage 87.56% <ø> (-0.18%) ⬇️
webclient ∅ <ø> (∅)
webserver 86.02% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ce7b5...919c5e3. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

GitHK
GitHK approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg sanderegg force-pushed the maintenance/update-aiohttp branch from 3550589 to d602648 Compare May 8, 2025 17:09
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sanderegg sanderegg merged commit 2d0ae68 into ITISFoundation:master May 9, 2025
94 of 95 checks passed
@sanderegg sanderegg deleted the maintenance/update-aiohttp branch May 9, 2025 08:05
@sanderegg sanderegg mentioned this pull request May 28, 2025
Open
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
Closed
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis bisgaard-itis is a code owner

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11

@mguidon mguidon Awaiting requested review from mguidon

Assignees

@sanderegg sanderegg

Labels

t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Bazinga!

Development

Successfully merging this pull request may close these issues.

4 participants

@sanderegg @giancarloromeo @GitHK @matusdrobuliak66